fix: show an error when knn_dist() is used in a custom ranker #3885
+48
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Windows test results 3 files 3 suites 25m 57s ⏱️ Results for commit 4ef0a54. ♻️ This comment has been updated with latest results. |
4 tasks
glookka
requested changes
Nov 10, 2025
Contributor
glookka
left a comment
glookka
left a comment
There was a problem hiding this comment.
In this code GetError() may return true if some other error is set (m_sLexerError, m_sParserError, m_sCreateError). So the first non-empty error should be returned
if ( GetError () )
{
if ( !m_sCreateError.IsEmpty() )
sError = m_sCreateError;
…er and parser errors
Collaborator
Author
Done in f724087 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #3602